totaldebug / atomic-calendar-revive

An advanced calendar card for Home Assistant Lovelace.
https://docs.totaldebug.uk/atomic-calendar-revive
MIT License
391 stars 63 forks source link

"descLength" option does not seem to change description length. #1326

Closed echo-lalia closed 5 months ago

echo-lalia commented 6 months ago

Is there an existing issue for this?

Current Behavior

Setting the descLength to an integer value does not appear to make any change to the display of event descriptions.

descLength: 10

image

Expected behaviour

The descriptions should be clipped to the number of characters provided to the descLength value. Or, at least, some change should happen when the value of descLength is changed.

Steps To Reproduce

This is all that is needed to reproduce the issue:

type: custom:atomic-calendar-revive
entities:
  - entity: calendar.{myEmail}
    name: {myEmail}
showDescription: true
descLength: 10

different values for descLength do not result in any different calendar display.

It's worth noting that the visual editor also has an option to set the description length, and the behaviour is the same.

Mode

Event (default)

Card Version

9.2.1

Home Assistant Version

2023.11.0

Configuration

type: custom:atomic-calendar-revive
entities:
  - entity: calendar.{myEmail}
    name: {myEmail}
showDescription: true
descLength: 10

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 6 months ago

Hello @echo-lalia, thank you for your interest in our work! If this is a bug report, please provide your configuration and any screenshots that would assist troubleshooting, otherwise we can not help you.

marksie1988 commented 6 months ago

I have just tested this and it is working fine, did you save the configuration or just view it in the preview? sometimes the preview doesnt update until the config is actually saved.

echo-lalia commented 6 months ago

Huh, I'm not sure how or why that is.

I was editing the yaml directly, and using a second monitor/window to view the changes, so I don't think that could've been the cause.

I would've been using Firefox, if there's a chance that's related, but otherwise I don't have a good guess. I'd like to investigate it again to be sure, but I'm a little busy for the next little while, with the holidays.

marksie1988 commented 5 months ago

Closing this as i dont believe it to be an issue, if there is some more evidence to show it as a bug i will re-open