search

totalimmersion / com.somfy.tahoma

Somfy TaHoma app for Homey
GNU General Public License v3.0
10 stars 16 forks source link

Fixed state and action used by the horizontal awning device #88

Closed fjeldstad closed 3 years ago

fjeldstad commented 4 years ago

In my installation, the horizontal awning device didn't work properly; its state was not read by the sync function and the command for setting the position (setClosure) seemed to be inverted. Through experimentation I've found a combination of state and action names that works for me.

What I'm a bit unsure of is whether or not this has to do with the physical device, so that maybe other users have functioning horizontal awnings (which could perhaps break if this change was applied). Tricky to tell. I only know that the device has never worked for me, and with the proposed changes it does work.

This fixes #87

fjeldstad commented 4 years ago

I'm going to run this version for a bit since I understand you @totalimmersion maybe don't have time to work on this app right now. I'll let you know if I encounter any issues.

Largus72 commented 4 years ago

Hi Hihaj,

I'm very interested in your version where you have fixed the state of a horizontal awning device. At this moment our sun-cover has no difference between half-open or closed. I would realy like an updated app where this is fixed.

Do you have any idea if your branch will be released anytime?

Onno

fjeldstad commented 4 years ago

I’ve tried to prepare it to be easy to merge and I’ve been running the fixed version for some time at home with no issues so far. But whether or not this fix will be properly released (and, if so, when) is out of my control.

tors 30 juli 2020 kl. 13:01 skrev Largus72 notifications@github.com:

Hi Hihaj,

I'm very interested in your version where you have fixed the state of a horizontal awning device. At this moment our sun-cover has no difference between half-open or closed. I would realy like an updated app where this is fixed.

Do you have any idea if your branch will be released anytime?

Onno

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/totalimmersion/com.somfy.tahoma/pull/88#issuecomment-666298591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG5EA3Z3HKGCAQYKXIOJKLR6FHHHANCNFSM4OQRNMNA .

aartse commented 4 years ago

i can confirm this PR 88 will fix the state / sync bug in this app.

in my case, when a io_horizontal_awning device is the first device returned in the sync, states of other devices will not update / change. with this fix, other device states will update again: https://github.com/aartse/com.somfy.tahoma/tree/fix-io_horizontal_awning-state