search

totaljs / Tangular

A simple JavaScript template engine like Angular.js for websites or node.js
MIT License
61 stars 21 forks source link

Prefer tangular than Tangular #8

Closed Darmody closed 7 years ago

Darmody commented 7 years ago

2017-02-17 16 05 54

petersirka commented 7 years ago

Hi, it works correctly:

image

I have tested it.

Darmody commented 7 years ago

Hm... But export variable name should be lower.

petersirka commented 7 years ago

I don't understand, for me it works correctly...

molda commented 7 years ago

Hi @Darmody the error comes from ESLint's eslint-plugin-import rule so it's actualy not a runtime error nor it's a syntax error or anything else. The rule just doesn't like it but the code will work anyways.

The naming convetion is entirely up to the writer of the code and can't be enforced.

You should be able to disable ESLint for the line require('tangular'); using following snippet

var Tangular = require('tangular'); // eslint-disable-line
Darmody commented 7 years ago

In my opnion, thinking Tangular is inconsistent, because package name is tangular.

@molda just want to make eslint green without disabling that rule, lol.

petersirka commented 7 years ago

@Darmody tangular has own reasons why is called tangular. This is not my fiction, it works correctly and this is important, nothing more.