search

totaljs / framework

Node.js framework
http://www.totaljs.com
Other
4.36k stars 450 forks source link

Added condition to exclude body from GET requests #689

Closed khaledkhalil94 closed 5 years ago

khaledkhalil94 commented 5 years ago

Adding a body to GET requests may lead to problems with some servers.

petersirka commented 5 years ago

I'm not sure with it. Can you create an example which can I test to some server? Because this change can affect existing projects...

khaledkhalil94 commented 5 years ago

I would need to message you privately because I'm using a private key and I can't expose it publicly.

petersirka commented 5 years ago

I'll try to look into it this week.

petersirka commented 5 years ago

I have added your fix. Just install $ npm install total.js@beta (it's stable). The fix has been added into the branch v3.2.0.

petersirka commented 5 years ago

Thank you!