search

totaljs / openplatform

OpenPlatform v5 is a beautiful and simple portal for running, integrating and managing multiple 3rd party web applications.
https://www.totaljs.com/openplatform/
MIT License
98 stars 48 forks source link

Seriously, great work, but some minor implementation issues... #19

Closed rwdim closed 1 year ago

rwdim commented 4 years ago

"value && value.items.length" is bad and is throwing errors.. in users-grid.html

Everywhere this kind of check is used should be replaced with 

values && Array.isArray( value.items ) ....

Current code assumes values is never null, and also that items is always a non-null array.

Also, in admin.html, this code fails when value is null.. there's no check...

    Thelpers.groups = function(value) {

        if (!value.length)
            return '';
Screen Shot 2019-10-25 at 12 02 52 PM
petersirka commented 4 years ago

Hmmm, value can't be null. Can you check server-side logs in terminal? Or can you send me the response from the server?

rwdim commented 4 years ago

Will do.

rwdim commented 4 years ago

Ok... it looks like you're developing in your master branch?, so I checked out v4.1.0 and it works as expected.

Not as pretty, but it seems to work. Clean checkout of master throws numerous errors when viewing the user list... /api/op/users/ generates an error response in json stating that column 'note' does not exist.

I'll play with v4.1 for now... thx :)

petersirka commented 1 year ago

On our end, it was an eternity instead of a delay. We prepared a brand-new version that includes all of the fixes. Really sorry.