PID file location choice/change

totallymike / ircnode

Extensible IRC bot written with node.js

https://github.com/totallymike/ircnode/wiki

MIT License

4 stars 2 forks source link

PID file location choice/change #39

Closed sigv closed 12 years ago

sigv commented 12 years ago

Currently IRC Node always stores it's PID for daemon in the /tmp/ircnode.pid file. This is usually fine, but if the user wants to start multiple daemons on the same computer for any reason (such as for a different irc server or on a shared system, for example, shell account) there will be problems.

I think the PID file should be stored (by default) in config_path/daemon.pid, but the IRC_NODE_PID_FILE env var should be prefered.

totallymike commented 12 years ago

This is good. The environment variable makes it a little easier to support an lsb-style init script.

sigv commented 12 years ago

Got this implemented on the pid_file_choose branch.

sigv commented 12 years ago

Pull request merged.