search

totallymike / ircnode

Extensible IRC bot written with node.js
https://github.com/totallymike/ircnode/wiki
MIT License
4 stars 2 forks source link

Automatically create required files #8

Closed sigv closed 12 years ago

sigv commented 12 years ago

The configuration files and folders the bot requires should be automatically created if they do not exist instead of just failing.

totallymike commented 12 years ago

I pulled the changes into a branch for some investigation. I noticed mixed usage of asynchronous vs synchronous calls to file system functions, so until we figure out how and when to use either in ircnode I'm keeping work on this isolated to a branch.

I'm closing the pull request, but as you can see the work is pulled into the file_create branch.

totallymike commented 12 years ago

Furthermore, while it's useful to create some of these directories, I'm not so sure we should let it run with default configurations. A default config file will lead the bot into wrong channels, and a default users file is a gaping security hole. Perhaps it should throw an error if these files are missing?

Maybe we should find a way to walk the user through creating the files if they're not found.