search

totara / totara-docker-dev

A docker setup to create a development environment for Totara Learn
MIT License
49 stars 32 forks source link

Add pgsql13 container #158

Closed markmetcalfe closed 3 years ago

samanthajayasinghe commented 3 years ago

It's already there :) https://github.com/totara/totara-docker-dev/blob/master/compose/pgsql.yml#L95

derschatta commented 3 years ago

it still does use pgsql 12 if you use the generic container name pgsql. As I've noted on a different PR changing the generic container to a different versions creates problems for users who already use that container, they first have to delete the old volume and container before being able to use the new version. I vote for going away from using the generic one and just use the container with the specific version, less friction in daily use and it's clear which version you are using

markmetcalfe commented 3 years ago

it still does use pgsql 12 if you use the generic container name pgsql. As I've noted on a different PR changing the generic container to a different versions creates problems for users who already use that container, they first have to delete the old volume and container before being able to use the new version. I vote for going away from using the generic one and just use the container with the specific version, less friction in daily use and it's clear which version you are using

Created #159 for this