search

totara / totara-docker-dev

A docker setup to create a development environment for Totara Learn
MIT License
49 stars 32 forks source link

Fix build for PHP 5.5 and earlier versions #198

Closed derschatta closed 2 years ago

derschatta commented 2 years ago

the build was failing with due to issues with ICU. I updated the base build with PHPBrew and modified the other versions which depend on it.

While doing that I also fixed the sourcing of custom shell scripts as this was done on build and not on runtime.

derschatta commented 2 years ago

@codyfinegan could you review/test this again if you find some time?

codyfinegan commented 2 years ago

@derschatta Shall do

codyfinegan commented 2 years ago

@derschatta Looks good, tested the 5.3, 5.4 & 5.5 images