totara / totara-docker-dev

A docker setup to create a development environment for Totara Learn
MIT License
49 stars 32 forks source link

Config.php default settings have poor performance #211

Closed KevinHottinger closed 2 years ago

KevinHottinger commented 2 years ago

Currently the config.php has caching turned off for graphql schemas, this was causing noticeable performance issues on the M1 and presumably for others.

The following line should be commented out by default to enable the cache $CFG->cache_graphql_schema = false;

The lang string cache should also be on by default $CFG->langstringcache = false;

derschatta commented 2 years ago

that's actually also my preferred way to do it as I can always purge caches when changing GraphQL queries. The schema generation has a huge impact on performance. Not only on M1 Macs.

derschatta commented 2 years ago

The langstringcache has minimal impact on my sites performance though, maybe that could be left in

derschatta commented 2 years ago

fixed in #226