totara / totara-docker-dev

A docker setup to create a development environment for Totara Learn
MIT License
49 stars 32 forks source link

Remove deprecated version lines from yml. #267

Closed lzabo closed 7 months ago

lzabo commented 7 months ago

it is a support to avoid getting warnings on the versions in the *.yml files.

Example message from the system: WARN[0000] /totara-docker-dev/docker-compose.yml: version is obsolete

derschatta commented 7 months ago

It looks like PHPStorm is losing "code" completion in docker compose files without the version tag :(. That's the main reason it was kept so far. But so far there has been no warning message about it.

derschatta commented 7 months ago

Hi @lzabo Thanks for your contribution. I noticed (too late) that this PR points to the wrong branch. Please create a new one based off the develop branch as described here: CONTRIBUTING.md