totem-technologies / totem

4 stars 0 forks source link

New: Add More Time to running session #400

Open micahp2 opened 2 years ago

micahp2 commented 2 years ago

To allow Keepers or Circle runners to add additional time to an in-progress session, we need to create a way to put this function very near to the countdown timer in the session UI. This view will allow the Keeper to add more minutes or remove minutes, in increments of 1 minute at a time. Changes to the time take place immediately upon exiting this dialog window.

Additionally, the Keeper can choose from this same UI to end the session entirely.

An example UI can be found here: https://drive.google.com/file/d/1TILXu_E1-6S61V-KLs_1ZbCUo0d2fhPI/view?usp=share_link

ansells commented 2 years ago

@micahp2 If you are already in "overtime" should you be able to add time to the session? I would think not, but if you did then it would need to be added from "now" and not the session end time, right?

Also, since you say you can "remove minutes" then I assume this value can go negative, correct?

micahp2 commented 2 years ago

@ansells here's what I would say to your questions:

Does that help?

ansells commented 2 years ago

Yep, very helpful. One last question. Once the session is in overtime should the menu button just go away? Or, perhaps we should put the "end session" as an option under that menu rather than in the dialog itself?

micahp2 commented 2 years ago

I would switch the button to the "end session" action and show that to the Keeper. That's a better use of that space than hiding or disabling the button.