Enhancement: Retrigger Image-Factory Build

totem / dashboard-v2

Totem v2 dashboard

MIT License

2 stars 1 forks source link

Enhancement: Retrigger Image-Factory Build #44

Open sukrit007 opened 8 years ago

sukrit007 commented 8 years ago

As a developer, I need ability to re-trigger image-factory build without having a need to go to github to trigger the hooks so that developers with non-admin privileges to repository can re-trigger the image-factory build for existing commit sha.

UPDATE Based on discussions with Josh, Christian we should:

Add a new button to our tools group (https://cloud.githubusercontent.com/assets/614753/14507171/50ef53ee-0176-11e6-8a3c-9f8b03fc6180.png)
Josh suggested we should use image from: https://design.google.com/icons/#ic_update
On triggering an update, user should be provided with dialog with options
- Rebuild image (This should re-trigger build in image factory for latest commit)
- Use existing image (with an option to specify url for existing image)

sukrit007 commented 8 years ago

@mmoulton @kennedyj @kennedyj @ctrimble @dtackett @jacobheun Thoughts ? Please update the issue.

ctrimble commented 8 years ago

Being able to rebuild from the image factory is good. It would be nice to have this button in the context of the service as well.

kennedyj commented 8 years ago

If the intent is to rebuild the image I think this would work well, I'd be curious to know what the circumstances are for rebuilding the same commit.

Most of the scenarios I've needed to re-trigger a hook for wasn't to build, but was instead to deploy the built image, this is overkill for that and we should use the orchestrator hook for triggering a re-deploy.

ctrimble commented 8 years ago

@kennedyj I hit this problem when a bug is discovered in a dependency. Since we do not have a good way to propagate dependency changes, this is a manual process.

ctrimble commented 8 years ago

In my use case, I usually just want to rebuild the last commit on a branch. It would be nice to have a button just for that, in the context of the deployed branch.

kennedyj commented 8 years ago

Thinking about it more, I think having the button with the app is more appropriate since the image factory jobs aren't persisted.

ctrimble commented 8 years ago

A new button in this group of tools would be sweet. screen shot 2016-04-13 at 12 49 04 pm

sukrit007 commented 8 years ago

I like the button in app group. Something like :

My use cases:

Trigger totem build when totem config is outside github repo.
Re-trigger failed image-factory builds which failed due to some intermittent connectivity issues while installing packages

The update option can give you 2 options:

Re-build image
Specify existing image (useful for OSS images built from docker hub)

kennedyj commented 8 years ago

I think the options are good and adding it to the button group sounds good.

Here's a link to the material icon for update, we can use any of the material icons easily though, https://design.google.com/icons/#ic_update