totersapp / asana-integration-test

0 stars 0 forks source link

Move final total logic into OrderFinalTotalRepo #16

Open abbood opened 5 years ago

abbood commented 5 years ago

Business Value Added

Simplify final total calculation to prevent bugs (and solve collect_cash bug)

Analysis

With the new auto-approve logic, some final total calculations that are made in EnRouteToClientController should be moved into OrderFinalTotalRepo. This will solve the collect_cash = 0 bug & make the code easier to read

Comments

Need to double check whether this would break for the type of orders that are not auto-approved. Unless we could just enable auto-approve for all orders