totpero / DeviceDetector.NET

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.
Apache License 2.0
343 stars 73 forks source link

NuGet-package is DEBUG-build -- should be RELEASE #44

Closed gfoidl closed 3 years ago

gfoidl commented 3 years ago

Version 4.2.0 is published as DEBUG build, instead of RELEASE.

grafik

StingyJack commented 3 years ago

When this is switched to Release, strongly consider embedding the PDB's

cd21h commented 3 years ago

SourceLink is better alternative to embedding pdb https://github.com/dotnet/sourcelink

gfoidl commented 3 years ago

SourceLink is quite orthogonal to debug symbols (pdbs). I agree with @StingyJack that pdbs should be embedded (nowadays). It's mainly for good and thorough diagnostics.

totpero commented 3 years ago

Hi @gfoidl check last release v4.3.0