search

totpero / DeviceDetector.NET

The Universal Device Detection library will parse any User Agent and detect the browser, operating system, device used (desktop, tablet, mobile, tv, cars, console, etc.), brand and model.
Apache License 2.0
348 stars 73 forks source link

Update mobile regexes file #55

Closed fpl1976 closed 2 years ago

fpl1976 commented 2 years ago

Copy mobiles.yml file from matomo project, with updated list of devices for more accurate detection.

fpl1976 commented 2 years ago

Hey @totpero I see the appveyor CI failed because of some tests failing. I will try to fix them locally and push them together with this PR, if you agree.

totpero commented 2 years ago

Hi @fpl1976 I check the updates from php version. In the last regexes files you can't only update de yaml files. You need tu update a lot of code from v6. Check the v6 branch that I made and my code. There you can contribute. I will try to update all the code to v6. Also implement ClientHints feature.

fpl1976 commented 2 years ago

Hi @fpl1976 I check the updates from php version. In the last regexes files you can't only update de yaml files. You need tu update a lot of code from v6. Check the v6 branch that I made and my code. There you can contribute. I will try to update all the code to v6. Also implement ClientHints feature.

Yeah I switched to v6 branch. I see that regexes there are already updated from the PHP project. Checking the tests locally.

Can you tell me what is missing there to be able to upload the new version?

totpero commented 2 years ago

We need to fix all the code to pass all the tests.