totsukatomofumi / pe

0 stars 0 forks source link

Invalid dates not disallowed #2

Open totsukatomofumi opened 2 years ago

totsukatomofumi commented 2 years ago

Screenshot 2022-11-11 at 4.37.28 PM.png

2022-02-31 is allowed even though February only has 28 days (29 on a leap year) if I recall.

Screenshot 2022-11-11 at 4.37.48 PM.png

The invalid date is allowed and will be recorded as 2022-02-28. This allowance of invalid inputs may leave users complacent and transforming of the date when recorded will leave users confused.

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid DEADLINE date accepted and truncated for addtask

Command(s)
addtask t/Prepare tutorial slides d/2022-02-31

image.png

Does not throw an invalid date error, instead adds a task on 28th February.

Expected: Invalid date error


[original: nus-cs2103-AY2223S1/pe-interim#4905] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Invalid dates are not accepted but rounded down to the nearest valid date. This only happens when the day is 31 or less (i.e the app does not accept if 2022-08-32 is entered).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Not specified in your user guide nor in the app itself, can affect typical usage.