Closed colemanw closed 9 months ago
@totten not sure how to trigger CI on this repo. retest this please
@totten CI errors due to php version:
Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 7.4.0". You are running 7.3.33.
@colemanw Yup. Future test runs here should use php74.
This change sounds reasonable 👍.
Note that I was doing some reorganizing while offline, which led a fairly big patch-set - which would have a merge-conflict on this file. (It moves this bit of code, although it doesn't substantively change those lines.) I've copied/ported this change to the other branch (#325) -- seems like the easiest way to avoid MC.
Noticed in some of the sprint PRs a
modified_date
was sneaking into the.aff.php
file.Excluding all
readonly
fields gets rid of that, and also don't need to hard-code unsetting "search_displays" because it's alsoreadonly
in the metadata.