search

totten / civix

CiviCRM Extension Builder
http://civicrm.org/
Other
56 stars 56 forks source link

Add entity-types-php@2 #343

Closed colemanw closed 4 months ago

colemanw commented 5 months ago

Adds new mixin from https://github.com/civicrm/civicrm-core/pull/29771

colemanw commented 5 months ago

@totten updated the minimum.

totten commented 5 months ago

Ah, erg. E2E\MixinMgmtTest.testEnableAllDisableAll ==> it makes sense for that assertion to fail... The specific number is a bit arbitrary, but it would have to bounce around with this.

TBH, I'm not really sure the benefit to separating this commit from the other parts of the project... (Like I view it opportunistically - if separating makes it easier, then well-and-good.)

totten commented 4 months ago

civibot, test this please

colemanw commented 4 months ago

@totten FIFY

totten commented 4 months ago

Yeah, fair enough. hook_entityTypes is totally a valid thing in 5.51... and storing the *.entityType.php in ./schema would be too.

There's other plumbing for the overall set of changes/expectations, but that needs to be sorted out in other PRs. Don't need to block this part.