search

totten / git-scan

CLI tool for scanning/updating git repos
33 stars 7 forks source link

Fix PHP8 and PHPUnit8 Compatability #18

Closed seamuslee001 closed 3 years ago

seamuslee001 commented 3 years ago

@totten I did a local test this weekend and this seems to be all that is needed for php8 support and also brings in with it your commits around the phpunit7 and phpunit8 issues

locally all unit tests pass

totten commented 3 years ago

That's great news!

For clarity - did a little diff, and this is a pick+squash from #17, minus the Symfony change, plus an opt-out for the extra 'cache result' file.

For regression-checking, I used php72 to try out phpunit{7,8}, and they were still happy.