totu / Swipe2Nav

Firefox Add-on to enable two-finger left and right gestures to navigate browser history
MIT License
18 stars 4 forks source link

Unintentional navigations when page requires horizontal scrolling #2

Closed totu closed 5 years ago

totu commented 5 years ago

If page is wider than screen, i.e. it requires horizontal scrolling the add-on will kick in even though we are not at the edge of the page.

This requires some kind of detector for the edges, so we know when the user actually wants to move backwards/forwards instead of just scroll sideways to view the content.

totu commented 5 years ago

Fixed in release 0.1.2

rdhar commented 4 years ago

Curiously, I can still observe this issue on v1.0.4 of SwipeToNavigate. I can replicate this using an external mouse and attempting to scroll horizontally with the scroll wheel.

totu commented 4 years ago

Hi, @rdhar

Sadly at the current state this addon is pretty much abandon-ware. I no longer have a Windows machine, so my needs for the addon are non-existent.

However I will accept a patch if you are wiling to prove one.

rdhar commented 4 years ago

Ah, that's a bit of a shame to hear.

It's still one of the best offerings to meet this need on Firefox add-ons. Really appreciate your response!