search

touchlab-lab / KotlinCocoapods

Apache License 2.0
75 stars 6 forks source link

Fix plugin id in README.md #2

Open alekseychugaev opened 4 years ago

alekseychugaev commented 4 years ago

Invalid plugin id in example, correct id should be

plugins {
  id("co.touchlab.native.cocoapods")
}
alekseychugaev commented 4 years ago

Also, before I could make it work for an existing project, I had to update podspec file as in here https://github.com/touchlab/KaMPKit/pull/76/files#diff-65c1831fff220b3ed58c09539ba5f0ec:

Screen Shot 2020-03-20 at 23 31 50

and reinstall pod.

Perhaps it's worth including some of it in README.md

shadowsheep1 commented 4 years ago

And here another issue in README.md

isStatic = false

must be

framework {
            isStatic = false
}

/cc @ben-whit-ley

shadowsheep1 commented 4 years ago

@alekseychugaev you don't need to modify the podspec file, you could generate it with the gradle task provided you set 

framework {
            isStatic = false
}
russhwolf commented 4 years ago

Acknowledging yes we could use a docs refresh here.