search

touchlab / CrashKiOS

Crash reporting for Kotlin/Native iOS applications
https://crashkios.touchlab.co/
Apache License 2.0
276 stars 15 forks source link

Tk/dynamic crashlytics #71

Closed TadeasKriz closed 1 month ago

TadeasKriz commented 3 months ago

I've replaced direct usage of Firebase Crashlytics ObjC classes with dynamic calls. This way stripped symbols are no longer a problem. The one symbol we still need to mark as "unresolved" (_FIRCLSExceptionRecordNSException) is available even after symbols are stripped. That means dyld is able to link it in runtime.

I've also made it into a weak symbol to improve the error message when we try to use it, but it's not available.

tamimattafi commented 3 months ago

@TadeasKriz Hello! Can we have a pre-release (alpha01 or something) so we can help with testing? I have a large dynamic framework which might trigger other side effects

JackHurst0 commented 1 month ago

Hello @TadeasKriz thanks for this fix!

Do you know if there is a timeline on when we could expect this to be merged and fixed?

kpgalligan commented 1 month ago

Sorry all. Review was on me and I've been super busy. Diving in...

JackHurst0 commented 1 month ago

Thanks once again for this fix @TadeasKriz

Just like @tamimattafi said, if you need real projects to test a pre-release, I can try to make some time to help with that.