double quotes around cocoapods curl header - Githubissues

touchlab / KMMBridge

KMMBridge is a set of Gradle tooling that facilitates publishing and consuming pre-built KMM (Kotlin Multiplatform Mobile) Xcode Framework binaries. See https://kmmbridge.touchlab.co/docs to get started.

https://kmmbridge.touchlab.co/

Apache License 2.0

339 stars 20 forks source link

double quotes around cocoapods curl header #225

Closed tmillz closed 2 months ago

tmillz commented 10 months ago

Issue: https://github.com/touchlab/KMMBridge/issues/224

Summary

Patches cocoapods dependency manager curl header for use on self-hosted runners with different curl versions.

Fix

Followed @TadeasKriz suggestion of adding double quotes around ["'Accept: application/octet-stream'"]

Testing

./gradlew test PASSED
./gradlew build PASSED
manual testing PASSED We deployed a 0.3.8-SNAPSHOT from my fork to maven local and used it in our project on our self-hosted runner. The curl command worked and pod lib lint was successful. Please let me know if you have any questions. Thanks!