touchlab / KMMBridge

KMMBridge is a tool that helps publish Kotlin Multiplatform (KMP) Xcode binaries for use from Swift Package Manager (SPM) and CocoaPods.
https://touchlab.co/kmmbridge/
Apache License 2.0
357 stars 20 forks source link

Extended GitLab Publishing for self managed instances #249 #250

Closed alaw-viator closed 2 months ago

alaw-viator commented 3 months ago

Issue: https://github.com/touchlab/KMMBridge/issues/249

Summary

The GitLab domain in the Maven config is fixed to gitlab.com and can't be configured for self-hosted e.g. gitlab.companyname.com

Fix

Testing

alaw-viator commented 3 months ago

@kpgalligan Appreciate this hasn't been in review very long, but given the size of it, if you or one of the other repo admins are able to take a quick look it'd be greatly appreciated. Thanks! 🙏

alaw-viator commented 2 months ago

@findjigar Would you be able to take a review on this? Thanks

alaw-viator commented 2 months ago

Would anyone else be able to take a review on this please, perhaps @samhill303? Thanks