search

touchlab / KaMPKit

KaMP Kit by Touchlab. A collection of code & tools designed to get your mobile team started quickly w/Kotlin Multiplatform
https://touchlab.co/
Apache License 2.0
2.2k stars 199 forks source link

Removed jcenter references #181

Closed shalomhalbert closed 3 years ago

shalomhalbert commented 3 years ago

Issue: None associated

Platform

Summary

JCenter is shutting down, which means that active projects should not rely on it. All of KaMPKit's dependencies are now available through other artifact repositories which means it's safe to remove JCenter from this project.

Fix

Removed references to JCenter.

Testing

Checked if syncing Gradle fails.

brady-aiello commented 3 years ago

Hey, thanks so much for this! CI is failing with:

* What went wrong:
Execution failed for task ':app:lint'.
> Could not resolve all files for configuration ':app:lintClassPath'.
   > Could not find org.jetbrains.trove4j:trove4j:20160824.
     Searched in the following locations:
       - https://kotlin.bintray.com/kotlinx/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom
       - https://dl.bintray.com/ekito/koin/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom
       - https://oss.sonatype.org/content/repositories/snapshots/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom
     Required by:
         project :app > com.android.tools.lint:lint-gradle:27.0.1 > com.android.tools:sdk-common:27.0.1
         project :app > com.android.tools.lint:lint-gradle:27.0.1 > com.android.tools.external.com-intellij:intellij-core:27.0.1

It looks like Jetbrains is still keeping at least one package in JCenter, and they haven't fixed that yet: https://youtrack.jetbrains.com/issue/KT-44730 https://youtrack.jetbrains.com/issue/IDEA-261387

russhwolf commented 3 years ago

That dependency comes in transitively from the Android Gradle Plugin. They've removed the dependency in 7.0.0 but keeping compatibility with stable IDEA means we need to stay on 4.0.x at the moment. I think the next IDEA version (2021.1) works with 4.1.x but 7.0.x probably won't hit until the version after that (2021.2)

shalomhalbert commented 3 years ago

Seems like I forgot to clear the project before syncing :(

thederputy commented 3 years ago

It looks like the trove4j:20160824 dependency has been moved to mavenCentral. If this gets re-built in CI it should now work.

https://youtrack.jetbrains.com/issue/IDEA-261387#focus=Comments-27-4820597.0-0 https://mvnrepository.com/artifact/org.jetbrains.trove4j/trove4j/20160824

brady-aiello commented 3 years ago

This is running the old Azure CI. Could you rebase to the latest to pick up the Github Actions workflows?

shalomhalbert commented 3 years ago

Yup, will do it in the morning :)

shalomhalbert commented 3 years ago

Pushed 👍 FWIW, this is the first PR I've ever made to an open-source repository...and the first time I used git rebase 😄

brady-aiello commented 3 years ago

Nice! Thanks for the contribution! Looking forward to your next one. The community makes the world go 'round.