search

touchlab / KaMPKit

KaMP Kit by Touchlab. A collection of code & tools designed to get your mobile team started quickly w/Kotlin Multiplatform
https://touchlab.co/
Apache License 2.0
2.2k stars 199 forks source link

Issue-194: Remove Bintray dependencies and update to latest Koin release #195

Closed russhwolf closed 3 years ago

russhwolf commented 3 years ago

Closes #194

[Platform]

[Summary]

We were still reading Koin from Bintray (oops!)

[Fix]

Update to release version of Koin which is published to Maven Central, and remove remaining stray Bintray dependencies

[Testing]

Unit tests still pass, and ran App on both platforms with no issues.

Reviewer Tips:
* Use "Nitpick:" if it's a minor non-crucial request.
* If you're done with comments either end with a review or comment something helpful like "done with comments for now"
russhwolf commented 3 years ago

That's weird. Nothing should be looking at that repository or for that coroutines version. From the error message, it looks like gradle offline mode might be giving you issues?

IgorGanapolsky commented 3 years ago

It is weird. I don't have gradle offline turned on. Are you able to build your branch? If so - which version of Android Studio are you running.

On Mon, May 3, 2021 at 4:00 PM Russell Wolf @.***> wrote:

That's weird. Nothing should be looking at that repository or for that coroutines version. From the error message, it looks like gradle offline mode might be giving you issues?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/touchlab/KaMPKit/pull/195#issuecomment-831498190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRD6NGVHNQM35GSHB6MPLTL36HHANCNFSM44BE2EJQ .

russhwolf commented 3 years ago

I think you're on the wrong branch. The code that's visible looks like an out-of-date version of Dependencies.kt and the commit sha b001ee83 belongs to a commit in an unmerged branch from a year ago.

russhwolf commented 3 years ago

Added more pre-1.5 version bumps and migrate to official cocoapods

IgorGanapolsky commented 3 years ago

It works now. Thanks! Any chance we could use kotlin = "1.5.0-RC" so that we are forward-compatible? According to JetBrains:

The only additional changes before the release will be fixes.

russhwolf commented 3 years ago

Libraries aren't all in place yet for 1.5

kpgalligan commented 3 years ago

Libraries aren't all in place yet for 1.5

Fact. There's usually a delay on things like Multithreaded coroutines, which holds up other libraries.