View Model Refactor Concept - Shared Interface - Githubissues

touchlab / KaMPKit

KaMP Kit by Touchlab. A collection of code & tools designed to get your mobile team started quickly w/Kotlin Multiplatform

https://touchlab.co/

Apache License 2.0

2.2k stars 199 forks source link

View Model Refactor Concept - Shared Interface #206

Closed brady-aiello closed 2 years ago

brady-aiello commented 3 years ago

Summary

The code in NativeViewModel and MainViewModel (Android) is nearly identical.

Fix

We can make them both implement an interface with mostly default functions, and keep platform-specific code minimal. Platform-specific stuff:

the CoroutineScope for each
exposing Flows through callbacks for iOS

Testing

./gradlew :app:build
./gradlew :shared:build
xcodebuild -workspace ios/KaMPKitiOS.xcworkspace -scheme KaMPKitiOS -sdk iphoneos -configuration Debug build -destination name="iPhone 8"
manual testing

kpgalligan commented 2 years ago

PR https://github.com/touchlab/KaMPKit/pull/238 is a merge of the view model concept PRs. Closing this one.