search

touchlab / KaMPKit

KaMP Kit by Touchlab. A collection of code & tools designed to get your mobile team started quickly w/Kotlin Multiplatform
https://touchlab.co/
Apache License 2.0
2.2k stars 199 forks source link

Duplication of version names inside build.gradle.kts? #234

Closed StylianosGakis closed 2 years ago

StylianosGakis commented 2 years ago

Inside the build.gradle.kts file, there are two definitions of a version, and they are also not on the same number.

Here: https://github.com/touchlab/KaMPKit/blob/18d1c0032956ff9f64983927bf2e0135e923dea0/shared/build.gradle.kts#L28 And Here: https://github.com/touchlab/KaMPKit/blob/18d1c0032956ff9f64983927bf2e0135e923dea0/shared/build.gradle.kts#L47

Is there any particular reason for this? If yes, it'd be great if it were somehow documented to help us understand how that would apply to our own projects too. If no, maybe remove one of them and keep the necessary one?

kpgalligan commented 2 years ago

Good question. They probably were added independently for various reasons, although we don't really use them. I know one was added to get cocoapods to not complain, but neither really has any "meaning". Will review.

kpgalligan commented 2 years ago

Note to whoever is doing this. I think one of these exists to tell cocoapods what to print, which technically doesn't matter as it's a local pod. I would take a quick look to see if there's an obvious reason we have the inner one (second link), and if not, just delete it and make sure everything continues on as expected.