search

touchlab / Kermit

Kermit by Touchlab is a Kotlin Multiplatform centralized logging utility.
https://kermit.touchlab.co
Apache License 2.0
699 stars 40 forks source link

Naming conflict and inconvenient #359

Closed k0shk0sh closed 11 months ago

k0shk0sh commented 1 year ago

Is there by any chance plans to change the class name to a unique name to the library to avoid having to scroll through multiple loggers just to import Kermit?

For now I workaround it by defining typealias Kermit = co.touchlab.kermit.Logger which definitely help, but im checking to see If you are open to the idea of changing the name and if so, I could support and open a PR.

Screenshot 2023-07-23 at 13 26 40

Cheers

findjigar commented 11 months ago

No plans for this as of now. Thanks for the suggestion.

kpgalligan commented 11 months ago

I would add a note here. I definitely see that adding yet another "Logger" isn't great. The new version of Kermit has modules designed so that the actual "public" face of Kermit is a small library on top of kermit-core, which really does the heavy lifting. It would be fairly easy to write a duplicate of the kermit module, specific to what you need, and use kermit-core under that to provide the plumbing. We may be doing this in some cases as it can make config easier in some contexts.

See Logger in the repo. That module has very little in it. We've had various API requests that all can't really be done. For example, info instead of i for the logging name. We kind of need to pick one standard, for better or worse, but making a custom API on top should be pretty quick.