JUnit dependency in runtime classpath

touchlab / Kermit

Kermit by Touchlab is a Kotlin Multiplatform centralized logging utility.

https://kermit.touchlab.co

Apache License 2.0

699 stars 40 forks source link

JUnit dependency in runtime classpath #385

Closed hodgdon closed 7 months ago

hodgdon commented 10 months ago

implementation(kotlin("test-junit")) should be applied to test configuration rather than main. https://github.com/touchlab/Kermit/blob/main/kermit/build.gradle.kts#L100C17-L100C53

ptitjes commented 9 months ago

Duplicates of #383.

@kpgalligan Is there a reason the main source-set depends on JUnit? This is blocking us from moving to 2.0 version.

anox1337 commented 9 months ago

This also blocks LeakCanary from running on debug builds.

Phaestion commented 7 months ago

This is a long running issue, we have an exclude rule in our dependency specification for this, it causes our gradle build and tests to fail. FYI this is our exlude statement:

implementation("co.touchlab:kermit:2.0.2") {
    exclude(group = "org.jetbrains.kotlin", module = "kotlin-test-junit")
}

findjigar commented 7 months ago

Fixed in version 2.0.3