Improve Actions Script - Githubissues

touhidurrr / iplist-youtube

An attempt to list all Youtube IPs at one place.

BSD 3-Clause "New" or "Revised" License

144 stars 34 forks source link

Improve Actions Script #4

Closed Nusab19 closed 12 months ago

Nusab19 commented 12 months ago

Changes:

Remove token from actions/checkout@v4 as by default it uses github action's token
Run the script in a separate task
Only Commit if changes are made
Show diff only if changes are made

Nusab19 commented 12 months ago

so this pull can be closed

touhidurrr commented 12 months ago

@Nusab19, not sure why you closed this pr. You cloud have resolved the issues than we could have merged this pr. For better pr manage you can also try opening pull requests from a different branch than a main. This way your changes of a pr can be tracked separately.

Nusab19 commented 12 months ago

@Nusab19, not sure why you closed this pr. You cloud have resolved the issues than we could have merged this pr. For better pr manage you can also try opening pull requests from a different branch than a main. This way your changes of a pr can be tracked separately.

I tried to just comment it. Accidentally pressed close with comments.

:33

Then thought, "okay, if this happened, then fine"

touhidurrr commented 12 months ago

Ok, then I will resolve these issues myself.