Open finepointcgi opened 3 years ago
Hi @finepointcgi
Thanks you for your work on this article&youtube video tutorial ;-)
It seems you made a mistake in your tutorial:
1) you compile godot-python, this generates a build/dist/
folder that contain what should be put into your project root folder (so a pythonscript.gdnlib
and an addons
folder). By the way, the release
command is here to generate a zip archive of the dist once compile, not for activating release compilation flags.
2) then you run the tests on the build. The first thing this does is downloading a Godot binary given the godot-python plugin alone cannot be tested
3) now you go to the build folder and run the Godot downloaded for the tests 😄
4) then you download the godot-python plugin from the asset store ! so the godot-python you've compiled is not used at all
As a matter of fact, regular user should only do step 4) (i.e. start their regular Godot, open their project, select asset store, download the godot-python plugin, restart Godot. done !)
I'll put this in my article and put a pinned comment that's my fault.
On Wed, Sep 1, 2021, 1:01 PM Emmanuel Leblond @.***> wrote:
Hi @finepointcgi https://github.com/finepointcgi
Thanks you for your work on this article&youtube video tutorial ;-)
It seems you made a mistake in your tutorial:
- you compile godot-python, this generates a build/dist/ folder that contain what should be put into your project root folder (so a pythonscript.gdnlib and an addons folder). By the way, the release command is here to generate a zip archive of the dist once compile, not for activating release compilation flags.
- then you run the tests on the build. The first thing this does is downloading a Godot binary given the godot-python plugin alone cannot be tested
- now you go to the build folder and run the Godot downloaded for the tests 😄
- then you download the godot-python plugin from the asset store ! so the godot-python you've compiled is not used at all
As a matter of fact, regular user should only do step 4) (i.e. start their regular Godot, open their project, select asset store, download the godot-python plugin, restart Godot. done !)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/touilleMan/godot-python/issues/308#issuecomment-910475639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3UWDBOPKGDIRPBRUYVVZ3T7ZL55ANCNFSM5DCMA5ZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Hey, I have created a YouTube video and article on how to set this all up for Windows. https://youtu.be/IafLArxKVjY and https://finepointcgi.io/2021/08/30/advanced-godot-integrating-python-into-godot/
Hope its useful Thanks, Mitch