search

toumorokoshi / tome

convert any directory of scripts into your own fully-featured command.
MIT License
38 stars 2 forks source link

Update fish shell completions to match new cli interface #42

Closed zph closed 1 year ago

zph commented 1 year ago

Hello @toumorokoshi !

When tome moved away from --complete style arguments it broke commandline completions for fish.

This patch resolves the issue and re-enables commandline completion.

Note: I'm putting this up as draft so that I can test drive it a few days before being confident in its correctness.

toumorokoshi commented 1 year ago

also ack on this being a draft - give me a ping when you feel it's ready.

toumorokoshi commented 1 year ago

@zph how is it working?

zph commented 1 year ago

@toumorokoshi It's working for me and I'm happy with the behavior. I've confirmed it completes intermediary folders, including nested folders and then the script names.

I've converted it from a draft and ready for review. Given that fish scripting is a bit esoteric, I left more comments than normal to help with future understanding.

zph commented 1 year ago

Also, after working on this PR, I think https://github.com/toumorokoshi/tome/issues/11 would be a nice enhancement as you suggested.

toumorokoshi commented 1 year ago

great! merged.

Yes #11 is on the backlog :) I have some more work to do with #40 and #41 anyway.

zph commented 1 year ago

Great thanks :)

I adopted tome to help with team level cli tooling and it's been going well. Thanks for building this project and welcoming contributions for it.