Opened Web TW Login after cancellation of Naive TW Login

touren / twitter-kit-ios

Twitter Kit is a native SDK to include Twitter content inside mobile apps.

Apache License 2.0

110 stars 80 forks source link

Opened Web TW Login after cancellation of Naive TW Login #9

Closed woshiyezu closed 4 years ago

woshiyezu commented 4 years ago

Using TwitterKit5, showed Web TW login after cancelling Native TW login.

Expected behavior

Come back app after cancelling Native TW login.

Actual behavior

Opened Web TW Login after cancellation of Native TW Login

Steps to reproduce the behavior

Just use TwitterKit5, open Native login and then cancel login on it.

touren commented 4 years ago

Can't reproduce in the Demo app within the project.

Check the code: https://github.com/touren/twitter-kit-ios/blob/master/TwitterKit/TwitterKit/TWTRTwitter.m#L380

Make sure using similar logic in your own method: (BOOL)application:(UIApplication )application openURL:(NSURL )url options:(NSDictionary *)options

Ref: https://github.com/twitter-archive/twitter-kit-ios/issues/122

woshiyezu commented 4 years ago

Thanks. I will try it.

fxsalazar commented 4 years ago

I did test the DemoAPP out the box and yes, the WebView still poping up after app cancelation. I spotted an anomaly (made a PR #13); Still wondering why couldn't you reproduce the behaviour 🤔