touretzkyds / oldWordEmbeddingDemo

Word embeddings online demo, rewrite
https://jxu.github.io/WordEmbeddingDemo/
1 stars 0 forks source link

leaving vector arithmetic mode #35

Closed touretzkyds closed 2 years ago

touretzkyds commented 3 years ago

If we expand the vector arithmetic panel the demo enters vector arithmetic mode so the user can try out analogies. When they collapse the panel and we go back to regular mode, the 6-row vector display is cleared, erasing the vectors for differences and sums etc. that we no longer want to display. So far, so good.

But if the user expands the vector arithmetic panel, then changes their mind and collapses it again without having actually done any vector arithmetic, the vector display is still good and we should not be clearing it.

touretzkyds commented 3 years ago

After discussion, we've changed the spec for what should happen when leaving vector arithmetic mode, assuming that the user has actually done some vector arithmetic. In this case we should:

If the user entered vector arithmetic mode and then left it again without actually doing any vector arithmetic, we shouldn't clear anything.

neelpawarcmu commented 2 years ago

Resolved

touretzkyds commented 2 years ago

Tested and verified.