search

tournament-js / tournament

A tournament base class for static tournament types
MIT License
64 stars 13 forks source link

restore does not restore match.data #32

Closed clux closed 8 years ago

clux commented 8 years ago

We have mandated that tournaments keep the data key on a match clean. However, this data is not really saved along with the normal state. I.e. if you use Duel.restore from database step as per https://github.com/clux/tournament/blob/427d3c25dd7cb2ffc40ed3b702fb81e9e46af05b/doc/base.md#serialization then this data is lost if you store it on the match.

Restore should be extended to handle match.data.

clux commented 8 years ago

A fix for this would close clux/duel#14

clux commented 8 years ago

Released in tournament@3.2.0

All tournament implementations get this version on reinstall due to the current versioning scheme.