As discussed in #1879, the vouchers are already described as public information, so it makes sense to include them in the public dataset.
A few other improvements in this PR:
files are written to the zip file on the fly, without loading the content in memory
an isolated session is created in the database with the isolation level repeatable read, to make sure the public dataset is internally consistent, even if updates happen during its creation.
Checklist
[x] I added the related issue(s) id in the related issues section (if any)
if not, delete the related issues section
[x] I described my changes and my decisions in the PR description
[x] I read the development guidelines of the CONTRIBUTING.md
[x] The tests pass and have been updated if relevant
Description
As discussed in #1879, the vouchers are already described as public information, so it makes sense to include them in the public dataset.
A few other improvements in this PR:
repeatable read, to make sure the public dataset is internally consistent, even if updates happen during its creation.Checklist