The back end has a new set of settings to allow the users to configure the feeds For you and Top items. The legacy settings starting with recommendations__ are kept to not break the old versions of the browser extension.
browser extension
The browser extension doesn't rely any more on the tournesol.app local storage to set the recommendations languages for anonymous users. The legacy strategy is now fully replaced by the usage of the extension local settings for anonymous users and by the "online" settings for logged-in users.
to-do
feed - for you
back end
[x] add new settings, and test them
[x] feed_foryou__languages
[x] feed_foryou__date
[x] feed_foryou__unsafe
[x] feed_foryou__exclude_compared_entities
[x] migrate the settings recommendations__ to feed_foryou__
front end
preferences
[x] add new fields
[x] add a new fieldset
[x] translate them
[x] fix the component tests
[x] fix and make the e2e tests more relevant
feed page
[x] use the settings
[x] initialize the languages
[x] use the poll setting defaultFiltersFeedForYou
[x] add a link to Preferences
[x] add a link to Search
[x] with the current search parameters
[x] check the deleted tests
tests
[x] add e2e tests of the new feed page
browser extension
[x] use the new setting feed_foryou__languages
feed - top videos
back end
[x] add a new settings, and test them
feed_topitems__languages
[x] add the preview
front end
preferences
[x] add new fields in the page Preferences
[x] translate them
[x] fix the component tests
[ ] fix and make the e2e tests relevant
side bar
[x] use the setting feed_topitems__languages
[x] use the poll setting defaultFiltersFeedTopItems
feed page
[x] use the settings
[x] initialize the languages
[x] sanitize the URL to remove all filters except date and languages
[x] add a link to Preferences
[x] add a link to Search
[x] with the current search parameters
tests
[x] add e2e tests of the new feed page
search
back end
[x] add the preview
front end
search page
[x] add a back button
[x] do not display when it's not required
[x] go back to the previous location path and parameters
[x] use Redux
recommendations
back end
[x] keep the legacy recommendations__ settings to not break older versions of the extension*
[x] keep the preview of /recommendations URL
front end
collective recommendations
keep the page for backward compatibility (and for the poll presidentielle2022)
[x] remove the share button? no
[x] add a info box inviting to go to the new address? no
use the Top items page in presidentielle2022 and remove the page collective recommendations
personal recommendations
refactor it later
PWA
[x] define the new entry point
preview
[x] don't break the preview
page - Preferences
create a generic field for the setting upload date
[x] create a generic field for the setting languages
clean-up:
[x] delete getRecommendationPageName? no, still used by the personal recommendations page
[x] delete getDefaultRecommendationsSearchParams
Next steps
refactor the personal recommendations page if needed
Checklist
[x] I added the related issue(s) id in the related issues section (if any)
if not, delete the related issues section
[ ] I described my changes and my decisions in the PR description
[x] I read the development guidelines of the CONTRIBUTING.md
[ ] The tests pass and have been updated if relevant
related issues #1983
Description
back end
The back end has a new set of settings to allow the users to configure the feeds For you and Top items. The legacy settings starting with
recommendations__
are kept to not break the old versions of the browser extension.browser extension
The browser extension doesn't rely any more on the tournesol.app local storage to set the recommendations languages for anonymous users. The legacy strategy is now fully replaced by the usage of the extension local settings for anonymous users and by the "online" settings for logged-in users.
to-do
feed - for you
feed_foryou__languages
feed_foryou__date
feed_foryou__unsafe
feed_foryou__exclude_compared_entities
recommendations__
tofeed_foryou__
defaultFiltersFeedForYou
feed_foryou__languages
feed - top videos
feed_topitems__languages
feed_topitems__languages
defaultFiltersFeedTopItems
search
recommendations
recommendations__
settings to not break older versions of the extension*/recommendations
URLpresidentielle2022
)presidentielle2022
and remove the page collective recommendationsPWA
preview
page - Preferences
create a generic field for the setting upload dateclean-up:
getRecommendationPageName
? no, still used by the personal recommendations pagegetDefaultRecommendationsSearchParams
Next steps
Checklist