search

tov / dssl2

A data structures student language, version 2
MIT License
9 stars 4 forks source link

array clone bugfix #28

Closed li-kangaroo closed 3 years ago

li-kangaroo commented 3 years ago

Removed an extra argument in the array constructor of the clone method that was giving an arity mismatch error

li-kangaroo commented 3 years ago

Yep, that's indeed an arity error. I'm guessing, though, that the intent was to do Array[T](self._len), i.e., copy the contract over to the clone, rather than dropping it. @tov: could you confirm?

Also, this bug would have been caught had there been a test case for Array.clone. @li-kangaroo: do you want to try adding one to the test suite, to guard against possible regressions?

Ahh, that makes much more sense. I'll open a fresh pull request that uses that definition as well as a test case once @tov confirms.