tov / dssl2

A data structures student language, version 2
MIT License
9 stars 5 forks source link

Fix printing of `time` case results to match documentation #36

Closed mpoelsterl1217 closed 1 week ago

mpoelsterl1217 commented 2 weeks ago

The results of time cases will now be printed with just timing information as documented.

Previously, the struct bundling the time case label, timing information, and result was printed naively.

stamourv commented 2 weeks ago

I like that. Did you test the lecture 6 benchmarks to make sure they still work? And can you work with Tochukwu to make sure the homework 3, 4, and project stress tests still work? Once you confirm that all of this works, please squash the commits into one then I'll merge. Thanks!

stamourv commented 2 weeks ago

FWIW, I confirmed on the grading side; that would have been complicated to set up. I'll let you do the benchmarks.

mpoelsterl1217 commented 1 week ago

I confirmed the lecture 6 benchmarks still work. time still returns the timing struct as that code expects (it is a little weird that this "statement" form produces a result). The change here changes how that struct gets printed.

stamourv commented 1 week ago

Thanks! Merged.