search

toverainc / willow

Open source, local, and self-hosted Amazon Echo/Google Home competitive Voice Assistant alternative
https://heywillow.io/
Apache License 2.0
2.63k stars 97 forks source link

Trailing slash in openHAB URL leads to error #374

Open happenpappen opened 6 months ago

happenpappen commented 6 months ago

When selecting "openHAB" as command endpoint in WAS and setting the openHAB URL to "https://:8443/" the client will call the rest api with URL "https://:8443//rest/..." like in this example:

`I (05:27:42.682) WILLOW/OPENHAB: sending 'Light on the bathroom.' to openHAB REST API on 'https://example.org:8443//rest/voice/interpreters'

I (05:27:43.198) WILLOW/HTTP: HTTP status='405' content_length='618' `

which will lead to an error "POST is not supported by this URL...". When i remove the trailing slash, the call will succeed.

Don't know, if this is more an openHAB or a Willow issue, but i think the double slash should be handled anywhere...

nikito commented 6 months ago

The issue is that technically, double slashes are allowed by the URL spec and normally it should work without issue, but maybe openHab doesn't like it. We could probably add some validation in the UI to not allow the user to enter a trailing slash. :)