search

towai / TromboneCharter

Bespoke .tmb charter for Trombone Champ customs.
MIT License
14 stars 7 forks source link

Update to Godot 4.2, add spectrogram generation, add Windows OpenGL builds, Steam Deck improvements #19

Closed DerpyChap closed 10 months ago

DerpyChap commented 10 months ago

This PR also hides the now redundant WAV conversion options. Waveform generation has also been improved and moved to its own thread, and it will now dynamically regenerate as the related options in the UI are changed.

The OpenGL build is untested, but theoretically should work. Hopefully closes #8, and makes #10 redundant.

Steam Deck changes involve detecting Steam Deck's Game Mode and forcing full screen, along with changing the windowing behaviour to embed any pop-up windows. Desktop Mode is unaffected.

DerpyChap commented 10 months ago

I've removed all WAV conversion/playback stuff and also added the ability to stop the playback of the preview along with binding playback to space. I'll refrain from adding anything else to this PR :P

Also I've just tested the OpenGL build and everything seems to work fine. I believe it requires OpenGL 3 so some people may still encounter compatibility issues on old/odd hardware. If they can't run OpenGL 3 but can run DX12 then there's https://apps.microsoft.com/detail/9NQPSL29BFFF?hl=en-us&gl=US as an alternative.

towai commented 10 months ago

You're the real MVP, i'm gonna pull this and maybe tweak one or two things (one thing i noticed is the preview button label doesn't go back to "Preview" if the preview stops of its own accord) but this looks pretty much ready to merge as-is just going by the diff

DerpyChap commented 10 months ago

one thing i noticed is the preview button label doesn't go back to "Preview" if the preview stops of its own accord

Ah oops, I forgot about that lol.