search

tower-rs / tower-http

HTTP specific Tower utilities.
702 stars 165 forks source link

Update deny config #375

Closed tottoto closed 1 year ago

tottoto commented 1 year ago

Motivation

Reflects the current state to cargo-deny config to fix cargo-deny test.

Solution

Updates it. Refs #374.

Nehliin commented 1 year ago

Do you mind trying to get the CI api check fix in here as well? otherwise I can do it a bit later but you'll have to rebase afterwards

tottoto commented 1 year ago

@Nehliin Sure. I'll take a look into it.

tottoto commented 1 year ago

cargo-public-api-crates checking fails in an empty crate as well with a similar error message.

$ cargo new --lib sample && cd $_
     Created library `sample` package

$ cargo public-api-crates check
 Documenting sample v0.1.0 (/home/test/sample)
    Finished dev [unoptimized + debuginfo] target(s) in 0.25s
Error: missing field `kind` at line 1 column 2930

I used the same version (e5ccdd37) with the green ci, which is also the current HEAD version.

I've also tried versions 1.65 through 1.69, with the same results, considering that there may have been some changes in Rust metadata.

Therefore cargo-public-api-crates doesn't seem to work right now. Additionally, this tool has not been released yet.

Should this checking be removed from tower-http ci?

Nehliin commented 1 year ago

No I don't think we should remove it but it doesn't need to block this pr for now