search

tower-rs / tower-http

HTTP specific Tower utilities.
680 stars 159 forks source link

Unbreak CI #385

Closed jplatte closed 1 year ago

jplatte commented 1 year ago

Motivation

CI is failing in other PRs, with no fault of the PR authors.

Solution

Stop erroring on duplicate dependencies in the cargo-deny check.

Nehliin commented 1 year ago

I'd rather have specific exceptions than accepting all duplicate dependencies

davidpdrsn commented 1 year ago

I'm okay either way 😅

jplatte commented 1 year ago

I'd rather have specific exceptions than accepting all duplicate dependencies

The problem with this, as mentioned in the commit message, is that CI frequently breaks from it from dependencies just doing their regular maintenance and upgrading dependencies. I also like avoiding duplicate dependencies, very much (recently went to upgrade syn in a bunch of places that hadn't upgraded to 2.0 yet). But more often than not, it's non-trivial to fix these and unrelated contributions get stuck on it, especially when the project isn't receiving frequent updates (like tower-http, currently).

Nehliin commented 1 year ago

Fair enough