search

tower-rs / tower-http

HTTP specific Tower utilities.
680 stars 159 forks source link

trace: Add default impls for Grpc #400

Closed LucioFranco closed 1 year ago

LucioFranco commented 1 year ago

This adds some default impls to allow the trace::ResponseBody to impl Default and satisfy tonic's requirements for using an interceptor.

LucioFranco commented 1 year ago

Tests seem to be failing for some reason? Outside of the changes I made that is

LucioFranco commented 1 year ago

I went ahead an ignored that test since it seems fixed on master, when we merge this branch back in we can enable it again.

LucioFranco commented 1 year ago

I don't know why the public crates thing is failing now....

tottoto commented 1 year ago

I think this is caused by recent nightly changes. (I've published a pull request (https://github.com/davidpdrsn/cargo-public-api-crates/pull/5) to fix this.)

LucioFranco commented 1 year ago

Thanks @tottoto for looking into this!