search

tower-rs / tower-http

HTTP specific Tower utilities.
680 stars 159 forks source link

enable clippy for tower-http and fix current issues #407

Open GlenDC opened 1 year ago

GlenDC commented 1 year ago

Motivation

I maintain a fork of tower, including also tower-http in https://github.com/plabayo/tower-async. Only now did I notice that tower-http does not yet enable clippy.

Nothing bad was spotted by enabling it, but still, seems by now that the Rust community agrees that enabling clippy everywhere is useful? So as such, here my first contribution upstream.

Solution

N/A

jplatte commented 10 months ago

Not sure why CI isn't running. I'll try closing and re-opening.

Oliboy50 commented 9 months ago

this PR should be rebased

GlenDC commented 9 months ago

this PR should be rebased

Probably, but the bigger issue is first to ensure maintainers want to merge this in to begin with. If this MR Is desired then I'll get the PR ready with pleasure. But until there is consensus on what to do with this PR there is no sense to put more effort into it.