util: Two call_all bug fixes

tower-rs / tower

async fn(Request) -> Result<Response, Error>

https://docs.rs/tower

MIT License

3.56k stars 281 forks source link

util: Two call_all bug fixes #709

Closed leoyvens closed 2 years ago

leoyvens commented 2 years ago

One is handling poll_ready errors, resolves #706.

The other is fixing the TODO about disarming poll_ready, since there is no disarm this makes sure poll_ready is only called if call will immediately follow. This one actually hit me in production.

Each bug fix has a corresponding test case. This should not be breaking any public API.

leoyvens commented 2 years ago

@LucioFranco Thank you for the review! Fast as a 🥷