towfiqi / serpbear

Search Engine Position Rank Tracking App
https://docs.serpbear.com/
MIT License
1.38k stars 135 forks source link

Resolve issue of duplicate entries in Dicover tab #184

Closed sachatrauwaen closed 5 months ago

sachatrauwaen commented 6 months ago

Issue Some time you get duplicates in the discover tab.

Analyse It hapen when google search api get more then 1 entry for a device/country/keyword. It is because the page is included in the dimentions of the google search console api call.

Solution I have not change the api call because the data is stored locally and used also in other tabs (with the page dimension). I grouped and sumerizing the stats in the Discover tab.

Remark : i included also an update of dev dependencies of react in package.json (i actually, dont know how to make a separate pull request for it)

sachatrauwaen commented 6 months ago

I make the changes

kevincerro commented 5 months ago

This PR looks great, anything more to do here?

sachatrauwaen commented 5 months ago

This PR looks great, anything more to do here?

No it's ready, waiting for review