fix: Correct CTR calculation in InsightStats component - Githubissues

towfiqi / serpbear

Search Engine Position Rank Tracking App

https://docs.serpbear.com/

MIT License

1.45k stars 145 forks source link

fix: Correct CTR calculation in InsightStats component #246

Closed lidarbtc closed 2 weeks ago

lidarbtc commented 3 weeks ago

Issue at #233

The CTR calculation was incorrectly summing up individual CTR values, resulting in inflated percentages. Now calculates CTR properly by dividing total clicks by total impressions.

Previous Implementation:

CTR was calculated by adding up individual CTR percentages
This resulted in artificially high CTR values
For example: [10%, 15%, 20%] => 45% (incorrect)

New Implementation:

CTR is now calculated using (total clicks / total impressions) * 100
This provides the actual click-through rate across all data
For example: (50 clicks / 1000 impressions) * 100 = 5% (correct)

This fix ensures accurate CTR reporting in the analytics dashboard.

Changes:

Removed CTR accumulation from reducer
Added proper CTR calculation based on total clicks and impressions
Maintains better statistical accuracy in reporting

towfiqi commented 2 weeks ago

Great Contribution! Thanks!